[Fix] no-unused-state: avoid a crash on type-only gDSFP declarations

Fixes #3225
jsx-eslint · Feb 27, 2022 · 9090999 · 9090999
1 parent e972bd7
commit 9090999
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,11 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
 
 ## Unreleased
 
+### Fixed
+* [`no-unused-state`]: avoid a crash on type-only gDSFP declarations ([#3225][] @ljharb)
+
+[#3225]: https://github.com/yannickcr/eslint-plugin-react/issues/3225
+
 ## [7.29.2] - 2022.02.25
 
 ### Fixed

diff --git a/lib/rules/no-unused-state.js b/lib/rules/no-unused-state.js
@@ -248,6 +248,7 @@ module.exports = {
       if (
         !node.static
         || name !== 'getDerivedStateFromProps'
+        || !node.value
         || node.value.params.length < 2 // no `state` argument
       ) {
         return false;

diff --git a/tests/lib/rules/no-unused-state.js b/tests/lib/rules/no-unused-state.js
@@ -1044,6 +1044,14 @@ eslintTester.run('no-unused-state', rule, {
         }
       `,
       features: ['ts'],
+    },
+    {
+      code: `
+        class AutoControlledComponent<P = {}, S = {}> extends UIComponent<P, S> {
+          static getDerivedStateFromProps: React.GetDerivedStateFromProps<any, any>
+        }
+      `,
+      features: ['types'],
     }
   )),