chore: define visitors if checkTypes is truthy

jsx-eslint · Aug 15, 2023 · 70c21f1 · 70c21f1
1 parent c984b4f
commit 70c21f1
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/lib/rules/sort-prop-types.js b/lib/rules/sort-prop-types.js
@@ -225,9 +225,6 @@ module.exports = {
     }
 
     function handleFunctionComponent(node) {
-      if (!checkTypes) {
-        return;
-      }
       const firstArg = node.params[0].typeAnnotation && node.params[0].typeAnnotation.typeAnnotation;
       if (firstArg && firstArg.type === 'TSTypeReference') {
         const propType = typeAnnotations.get(firstArg.typeName.name)
@@ -252,7 +249,7 @@ module.exports = {
       }
     }
 
-    return {
+    return Object.assign({
       CallExpression(node) {
         if (!sortShapeProp || !isShapeProp(node) || !(node.arguments && node.arguments[0])) {
           return;
@@ -328,9 +325,9 @@ module.exports = {
           typeAnnotations.set(node.id.name, currentNode);
         }
       },
-
+    }, checkTypes ? {
       FunctionDeclaration: handleFunctionComponent,
       ArrowFunctionExpression: handleFunctionComponent,
-    };
+    } : null);
   },
 };