[Fix] no-object-type-as-default-prop: enable rule for components wi…

…th many parameters
jsx-eslint · Jun 13, 2024 · 62e7638 · 62e7638
1 parent a944aa5
commit 62e7638
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/lib/rules/no-object-type-as-default-prop.js b/lib/rules/no-object-type-as-default-prop.js
@@ -30,7 +30,7 @@ const messages = {
 function hasUsedObjectDestructuringSyntax(params) {
   return (
     params != null
-    && params.length === 1
+    && params.length >= 1
     && params[0].type === 'ObjectPattern'
   );
 }

diff --git a/tests/lib/rules/no-object-type-as-default-prop.js b/tests/lib/rules/no-object-type-as-default-prop.js
@@ -143,6 +143,11 @@ ruleTester.run('no-object-type-as-default-prop', rule, {
         return null;
       };
     `,
+    `
+      const Foo = ({bar = 1}, context) => {
+        return null;
+      };
+    `,
     `
       export default function NotAComponent({foo = {}}) {}
     `
@@ -183,6 +188,24 @@ ruleTester.run('no-object-type-as-default-prop', rule, {
         }
       `,
       errors: expectedViolations,
+    },
+    {
+      code: `
+        const Foo = ({
+          a = {},
+          b = ['one', 'two'],
+          c = /regex/i,
+          d = () => {},
+          e = function() {},
+          f = class {},
+          g = new Thing(),
+          h = <Thing />,
+          i = Symbol('foo')
+        }, context) => {
+          return null;
+        }
+      `,
+      errors: expectedViolations,
     }
   )),
 });