[FIX] display-name: Get rid of false position on component detection

fixes #2751
jsx-eslint · Aug 15, 2020 · 5fc6de8 · 5fc6de8
1 parent f55ecaa
commit 5fc6de8
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 7 deletions.
diff --git a/lib/rules/display-name.js b/lib/rules/display-name.js
@@ -102,7 +102,7 @@ module.exports = {
       const namedFunctionExpression = (
         astUtil.isFunctionLikeExpression(node)
         && node.parent
-        && (node.parent.type === 'VariableDeclarator' || node.parent.method === true)
+        && (node.parent.type === 'VariableDeclarator' || node.parent.type === 'Property' || node.parent.method === true)
         && (!node.parent.parent || !utils.isES5Component(node.parent.parent))
       );
 
@@ -159,15 +159,10 @@ module.exports = {
       },
 
       ArrowFunctionExpression(node) {
-        /* eslint-disable */
-        console.log('*******************')
-        console.log(node)
-        console.log('*******************')
-        /* elsint-enable */
-
         if (ignoreTranspilerName || !hasTranspilerName(node)) {
           return;
         }
+
         if (components.get(node)) {
           markDisplayNameAsDeclared(node);
         }

diff --git a/tests/lib/rules/display-name.js b/tests/lib/rules/display-name.js
@@ -908,5 +908,21 @@ ruleTester.run('display-name', rule, {
     errors: [{
       message: 'Component definition is missing display name'
     }]
+  }, {
+    code: `
+      const x = {
+        title: "URL",
+        dataIndex: "url",
+        key: "url",
+        render: url => (
+          <a href={url} target="_blank" rel="noopener noreferrer">
+            <p>lol</p>
+          </a>
+        )
+      }
+    `,
+    options: [{ignoreTranspilerName: true}],
+    parser: parsers.BABEL_ESLINT,
+    errors: [{message: 'Component definition is missing display name'}]
   }]
 });