add more test cases

jsx-eslint · Jul 16, 2022 · 5118610 · 5118610
1 parent f274112
commit 5118610
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 3 deletions.
diff --git a/lib/rules/forbid-prop-types.js b/lib/rules/forbid-prop-types.js
@@ -66,11 +66,11 @@ module.exports = {
     function isPropTypesPackage(node) {
       return (
         node.type === 'Identifier'
-        && node.name === propTypesPackageName
+        && (node.name === null || node.name === propTypesPackageName)
       ) || (
         node.type === 'MemberExpression'
         && node.property.name === 'PropTypes'
-        && node.object.name === reactPackageName
+        && (node.object.name === null || node.object.name === reactPackageName)
       );
     }
 
@@ -218,7 +218,6 @@ module.exports = {
           node.callee.object
           && !isPropTypesPackage(node.callee.object)
           && !propsUtil.isPropTypesDeclaration(node.callee)
-          && node.callee.object.name !== 'PropTypes'
         ) {
           return;
         }

diff --git a/tests/lib/rules/forbid-prop-types.js b/tests/lib/rules/forbid-prop-types.js
@@ -654,6 +654,27 @@ ruleTester.run('forbid-prop-types', rule, {
           })
         )
       `,
+    },
+    {
+      code: `
+        import CustomPropTypes from "prop-types";
+        class Component extends React.Component {};
+        Component.propTypes = {
+          a: CustomPropTypes.shape({
+            b: CustomPropTypes.String,
+            c: CustomPropTypes.number.isRequired,
+          })
+        }
+      `,
+    },
+    {
+      code: `
+        import CustomReact from "react"
+        class Component extends React.Component {};
+        Component.propTypes = {
+          b: CustomReact.PropTypes.string,
+        }
+      `,
     }
   )),