Merge pull request #89 from zertosh/more-sort-comp

Add context props to sort-comp
jsx-eslint · May 29, 2015 · 3da7535 · 3da7535
2 parents ab7d219 + ec1c62b
commit 3da7535
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/docs/rules/sort-comp.md b/docs/rules/sort-comp.md
@@ -6,7 +6,7 @@ When creating React components it is more convenient to always follow the same o
 
 With default configuration the following organisation must be followed:
 
-  1. lifecycle methods: `displayName` ,`propTypes` ,`mixins` ,`statics` ,`getDefaultProps` ,`getInitialState` ,`componentWillMount` ,`componentDidMount` ,`componentWillReceiveProps` ,`shouldComponentUpdate` ,`componentWillUpdate` ,`componentDidUpdate` ,`componentWillUnmount` (in this order).
+  1. lifecycle methods: `displayName` ,`propTypes` ,`contextTypes` ,`childContextTypes` ,`mixins` ,`statics` ,`getDefaultProps` ,`getInitialState` ,`getChildContext` ,`componentWillMount` ,`componentDidMount` ,`componentWillReceiveProps` ,`shouldComponentUpdate` ,`componentWillUpdate` ,`componentDidUpdate` ,`componentWillUnmount` (in this order).
   2. custom methods
   3. `render` method
 
@@ -59,10 +59,13 @@ The default configuration is:
     lifecycle: [
       'displayName',
       'propTypes',
+      'contextTypes',
+      'childContextTypes',
       'mixins',
       'statics',
       'getDefaultProps',
       'getInitialState',
+      'getChildContext',
       'componentWillMount',
       'componentDidMount',
       'componentWillReceiveProps',

diff --git a/lib/rules/sort-comp.js b/lib/rules/sort-comp.js
@@ -56,10 +56,13 @@ module.exports = function(context) {
       lifecycle: [
         'displayName',
         'propTypes',
+        'contextTypes',
+        'childContextTypes',
         'mixins',
         'statics',
         'getDefaultProps',
         'getInitialState',
+        'getChildContext',
         'componentWillMount',
         'componentDidMount',
         'componentWillReceiveProps',

diff --git a/tests/lib/rules/sort-comp.js b/tests/lib/rules/sort-comp.js
@@ -26,10 +26,13 @@ eslintTester.addRuleTest('lib/rules/sort-comp', {
       'var Hello = React.createClass({',
       '  displayName : \'\',',
       '  propTypes: {},',
+      '  contextTypes: {},',
+      '  childContextTypes: {},',
       '  mixins: [],',
       '  statics: {},',
       '  getDefaultProps: function() {},',
       '  getInitialState: function() {},',
+      '  getChildContext: function() {},',
       '  componentWillMount: function() {},',
       '  componentDidMount: function() {},',
       '  componentWillReceiveProps: function() {},',