[Fix] display-name: fix false positive for HOF returning only nulls

jsx-eslint · May 20, 2022 · 30423b7 · 30423b7
1 parent 91d3757
commit 30423b7
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/lib/util/Components.js b/lib/util/Components.js
@@ -498,8 +498,13 @@ function componentRule(rule, context) {
           return undefined;
         }
 
-        // case: function any() { return (props) { return not-jsx-and-not-null } }
-        if (node.parent.type === 'ReturnStatement' && !utils.isReturningJSX(node) && !utils.isReturningOnlyNull(node)) {
+        // case: const any = () => { return (props) => null }
+        // case: const any = () => (props) => null
+        if (
+          (node.parent.type === 'ReturnStatement' || (node.parent.type === 'ArrowFunctionExpression' && node.parent.expression))
+          && !utils.isReturningJSX(node)
+          && !utils.isReturningOnlyNull(node)
+        ) {
           return undefined;
         }
 

diff --git a/tests/lib/rules/display-name.js b/tests/lib/rules/display-name.js
@@ -579,6 +579,15 @@ ruleTester.run('display-name', rule, {
         }
       `,
     },
+    {
+      // issue #3289
+      code: `
+        export const demo = (a) => (b) => {
+          if (a == null) return null;
+          return b;
+        }
+      `,
+    },
   ]),
 
   invalid: parsers.all([