Merge pull request #36 from burnnat/computed-prop-types

Fix prop-types to check for computed prop names
jsx-eslint · Mar 29, 2015 · 1577129 · 1577129
2 parents 0d7b069 + 3b5cf97
commit 1577129
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/rules/prop-types.js b/lib/rules/prop-types.js
@@ -129,7 +129,7 @@ module.exports = function(context) {
   function markPropTypesAsUsed(node) {
     var component = getComponent(node);
     var type;
-    if (node.parent.property && node.parent.property.name) {
+    if (node.parent.property && node.parent.property.name && !node.parent.computed) {
       type = 'direct';
     } else if (
       node.parent.parent.declarations &&

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -81,6 +81,18 @@ eslintTester.addRuleTest('lib/rules/prop-types', {
       ecmaFeatures: {
         jsx: true
       }
+    }, {
+      code: [
+        'var Hello = React.createClass({',
+        '  render: function() {',
+        '    var propName = "foo";',
+        '    return <div>Hello World {this.props[propName]}</div>;',
+        '  }',
+        '});'
+      ].join('\n'),
+      ecmaFeatures: {
+        jsx: true
+      }
     }, {
       code: [
         'var Hello = React.createClass({',