-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🎸 message-format cache compiled messages #360
feat: 🎸 message-format cache compiled messages #360
Conversation
Hi @k3nsei LGTM, but I don't think we want that as default behavior, so let's add it as an option in the plugin's configuration and make it "false" by default. |
@shaharkazaz yes I will do that. |
MessageFormatTranspiler transpile method compile messages to fn everytime it has ben called. Those generated fns can be cached and reused. Because result is always the same. Only parameters which those fns take can vary. Signed-off-by: Piotr Stępniewski <[email protected]>
Hi @k3nsei, thanks for the update.
Thanks! |
@k3nsei Hey! These are the fixes needed:
We're here if you need assistance. Let's merge this thing. 💪 |
@itayod You can pick it up. I can't find free time to move it forward. |
No rush, feel free to continue work on this when you can. |
Added in v3 |
@shaharkazaz @k3nsei Hi! What is the fate of this feature request? |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Message format compile is always used.
Issue Number: #358
What is the new behavior?
Message format use compile only once per message.
Does this PR introduce a breaking change?
Other information
none