Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Put transloco.module in its own folder #319

Merged
merged 4 commits into from
Aug 3, 2020

Conversation

karmasakshi
Copy link
Contributor

@karmasakshi karmasakshi commented Jul 29, 2020

Prevent Angular CLI generator from asking module name when generating
items by putting transloco.module in its own folder

Closes: #318

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Prevent Angular CLI generator from asking module name when generating
items by putting transloco.module in its own folder

Closes: jsverse#318
@itayod
Copy link
Contributor

itayod commented Jul 29, 2020

@karmasakshi make sure to also update the import path of the transloco-root.module file since we moved it under transloco folder

Module path of transloco-root.module updated

Closes: jsverse#318
@karmasakshi
Copy link
Contributor Author

Closing until I've tested.

@karmasakshi karmasakshi reopened this Jul 30, 2020
@karmasakshi
Copy link
Contributor Author

@itayod Over to you.

@itayod
Copy link
Contributor

itayod commented Jul 30, 2020

@karmasakshi LGTM :), did you manage to test it?

Environment path inside transloco.module updated.

Closes: jsverse#318
@karmasakshi
Copy link
Contributor Author

karmasakshi commented Jul 30, 2020

@itayod Used npm link to run schematic in sample app. Built and ran sample app with a translation. Ran existing tests and generated component using Angular CLI. Everything is working fine now.

@karmasakshi karmasakshi reopened this Jul 30, 2020
@itayod
Copy link
Contributor

itayod commented Aug 3, 2020

@karmasakshi LGTM, thanks 👍

@itayod itayod merged commit b54be7e into jsverse:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Having transloco-root.module confuses Angular CLI generator
2 participants