Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 table generation stuck (#196) #199

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

MikeDabrowski
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #196

What is the new behavior?

Behavior stays the same, slight visual changes may be seen. Changed the table generating library because cli-table3 is a performance nightmare.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@shaharkazaz
Copy link
Collaborator

Can you please downgrade to [email protected]? As stated in the issue you linked, the performance decreased dramatically in v0.6.2 and I think I prefer to keep using cli-table3 as cli-table is unmaintained at all as opposed to cli-table3.

Downgrading cli-table3 to "0.6.1" because later versions have degraded performance.
@MikeDabrowski
Copy link
Contributor Author

MikeDabrowski commented Jun 14, 2024 via email

@shaharkazaz shaharkazaz merged commit 03f6d4f into jsverse:master Jun 14, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants