fix: 🐛 comments with prefix not extracted (#197)

[MikeDabrowski]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/jsverse/transloco/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #197

What is the new behavior?

Added support for 'prefix' in comments. I also noticed that prefix is not supported at all. I can do it but will take some time.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

[shaharkazaz]

Thanks! Please update you branch from master and I'll merge 👏

[MikeDabrowski]

@shaharkazaz this is only for comments, to my knowledge no other part work with prefix yet. Can you confirm? I can do the rest as well next week

[shaharkazaz]

The directive should support prefix already, the comments were missed I guess.
I recommend recreating your branch from master or taking all the changes I've pushed as I completely refactored the tests structure

[MikeDabrowski]

Ok, I can do that tomorrow

…

On Thu, Jun 13, 2024 at 4:30 PM Shahar Kazaz ***@***.***> wrote: The directive should support prefix already, the comments were missed I guess. I recommend recreating your branch from master or taking all the changes I've pushed as I completely refactored the tests structure — Reply to this email directly, view it on GitHub <#198 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEICW37FOWKVPTGOLTBCCC3ZHGUHHAVCNFSM6AAAAABJEX4Q52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRVHA2DKOJSGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[MikeDabrowski]

I went over the rest and it seems there are traces of 'prefix'/'road' included. So this should be the final piece.

Tests however do not pass - They are broken on master at the moment. The test for comments did pass though.