change prefix in piler.js

[th-2021]

This patch sets base_url in piler.js according to the setting on config-site.php.

[jsuto]

I'd rather like to see a simpler solution. Eg. just set PATH_PREFIX as a docker-compose env var, and if it exists in the container then you simply use sed to fix piler.js, and update config-site.php with this value, eg. $config['PATH_PREFIX'] = ....; if it's not already in the file.

Also, please use $( ... ) format for running commands, not the obsoleted backtick (`)

[th-2021]

what about $config['SITE_URL'] = 'http://' . $config[SITE_NAME_CONST] . '/mail/';
Should I change util/config-site.php.in to have PATH_PREFIX in it and replace it in start with the real PATH_PREFIX?

[jsuto]

Yes, you are correct. I suggest to add config['PATH_PREFIX'] = '/'; to util/config-site.php.in before the SITE_URL line.

[jsuto]

And also fix etc/config-site.dist.php as well, please.

[jsuto]

This won't cut it, see my next comment below.

[jsuto]

PATH_PREFIX is a non-existing variable. What we need is

$config['PATH_PREFIX'] = '/';
$config['SITE_URL'] = 'http://' . $config[SITE_NAME_CONST] . $config['PATH_PREFIX'];

Then in start.sh you need to fix $config['PATH_PREFIX'] = '/';

[th-2021]

I used PATH_PREFIX like HOSTNAME in the file. and replaced it with the env variable in start.sh I also added $config['PATH_PREFIX'].
In my setup it looks like:
...
$config['SITE_URL'] = 'http://' . $config[SITE_NAME_CONST] . '/mail/';
...
$config['PATH_PREFIX'] = '/mail/';
...

Adding $config['PATH_PREFIX'] is an little bit more tricky.

[jsuto]

OK, it looks good. However, there's an issue, see #167. The problem is that with the current setup you can't override the BRANDING_* variables, so they need to be restored to the original place as they were. Please check out the other PR, and we need to come to an agreement how to solve this catch 22 issue.