Apply suggestions from code review

Co-authored-by: Bob Evans <[email protected]>
jsumners-nr · Oct 4, 2024 · a564237 · a564237
1 parent d9ab77b
commit a564237
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/test/versioned/fastify/add-hook.test.js b/test/versioned/fastify/add-hook.test.js
@@ -116,7 +116,7 @@ test('non-error hooks', async (t) => {
   await fastify.listen({ port: 0 })
   const address = fastify.server.address()
   const result = await common.makeRequest(address, '/add-hook')
-  match(result, { hello: 'world' })
+  assert.deepEqual(result, { hello: 'world' })
 
   // verify every hook was called after response
   for (const [hookName, isOk] of Object.entries(ok)) {
@@ -177,7 +177,7 @@ test('error hook', async function errorHookTest(t) {
   const address = fastify.server.address()
   const result = await common.makeRequest(address, '/error')
   assert.ok(ok)
-  match(result, {
+assert.deepEqual(result, {
     statusCode: 500,
     error: 'Internal Server Error',
     message: 'test onError hook'

diff --git a/test/versioned/fastify/code-level-metrics-hooks.test.js b/test/versioned/fastify/code-level-metrics-hooks.test.js
@@ -76,7 +76,7 @@ async function performTest(t) {
   const address = fastify.server.address()
   const result = await common.makeRequest(address, '/add-hook')
 
-  match(result, { hello: 'world' })
+  assert.deepEqual(result, { hello: 'world' })
 
   assert.equal(txPassed, true, 'transactionFinished assertions passed')
 }

diff --git a/test/versioned/fastify/naming-common.js b/test/versioned/fastify/naming-common.js
@@ -72,7 +72,7 @@ module.exports = async function runTests(t, getExpectedSegments) {
     await fastify.listen()
     const address = fastify.server.address()
     const result = await makeRequest(address, '/params/id/parent/edit')
-    match(result, { id: 'id', parent: 'parent' })
+    assert.deepEqual(result, { id: 'id', parent: 'parent' })
 
     assert.equal(txPassed, true, 'transactionFinished assertions passed')
   })