Health: Add clippy linting
#269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryutamago
changed the title
ryutamago
force-pushed
the
add-lint-check
branch
2 times, most recently
from
53bd935 to
8d38181
Compare
ryutamago
changed the title
make lint command / refactor
ryutamago
requested review from
johnyob,
alanmarkoTrilitech and
sam-finch-tezos
and removed request for
johnyob
johnyob
reviewed
Dec 13, 2023
johnyob
changed the title
make lint command / refactor clippy linting
|
It would also be good to split the existing |
Co-authored-by: Alistair <[email protected]>
ryutamago
force-pushed
the
add-lint-check
branch
from
eda62b3 to
706f64e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR introduces a new command
make lintthat uses clippy and apply them during pre-push / pipeline.Additionally, i refactored the code so that there will be no linting warnings. The first commit is auto generated by cargo clippy and i manually fixed the linting issues in the last commit.
Make sure you run
scripts/install-hooks.shto install the pre-push-hook script.Asana Task: Add linting to ci/pre-push hook
We also disable clippy::expect-fun-call rule due to the issue here.
Manually testing the PR
scripts/install-hooks.shto install the pre-push-hook script and try pushing with warnings.