Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Gem push error code being lost #11

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Fixed: Gem push error code being lost #11

merged 1 commit into from
Jul 19, 2022

Conversation

jcavalieri
Copy link
Contributor

@jcavalieri jcavalieri commented Jul 19, 2022 •
edited
Loading

Using find + exec loses the error code from gem push. Using xargs instead retains the error code and will actually fail the action.

fixes #10

@jcavalieri jcavalieri mentioned this pull request Jul 19, 2022
Closed
jstastny
jstastny approved these changes Jul 19, 2022
View reviewed changes
Copy link
Owner

@jstastny jstastny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution!

@jstastny jstastny merged commit 964589f into jstastny:master Jul 19, 2022
@jstastny
Copy link
Owner

This is now part of v2.2

@jcavalieri jcavalieri deleted the exit-code-fix branch July 19, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstastny jstastny jstastny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The configuration continue-on-error is not set to true, but action still succeeds
2 participants
@jcavalieri @jstastny