Skip to content

Address review feedback: update remaining vote rewards references#3453

Merged
jstarry merged 1 commit intorefactor/reward-commissionfrom
claude/review-pr-fixes-lbejV
Feb 4, 2026
Merged

Address review feedback: update remaining vote rewards references#3453
jstarry merged 1 commit intorefactor/reward-commissionfrom
claude/review-pr-fixes-lbejV

Conversation

@jstarry
Copy link
Copy Markdown
Owner

@jstarry jstarry commented Feb 4, 2026

  • Update doc comments in accumulate_into_larger to use "reward commissions" instead of "vote rewards"
  • Update doc comment in recalculate_partitioned_rewards_if_active to use "reward commissions" instead of "vote rewards"
  • Rename local variable vote_rewards to commission_lamports in redeem_rewards match arm for consistency

https://claude.ai/code/session_01Y2LeeQn5tiVcF8csejdhjS

Problem

Summary of Changes

Fixes #

- Update doc comments in accumulate_into_larger to use "reward
  commissions" instead of "vote rewards"
- Update doc comment in recalculate_partitioned_rewards_if_active
  to use "reward commissions" instead of "vote rewards"
- Rename local variable `vote_rewards` to `commission_lamports` in
  redeem_rewards match arm for consistency

https://claude.ai/code/session_01Y2LeeQn5tiVcF8csejdhjS
@jstarry jstarry merged commit e594feb into refactor/reward-commission Feb 4, 2026
1 of 2 checks passed
@jstarry jstarry deleted the claude/review-pr-fixes-lbejV branch February 4, 2026 06:06
jstarry added a commit that referenced this pull request Feb 4, 2026
…10343)

* Generalize naming of vote rewards to reward commissions

* Address review feedback: update remaining vote rewards references (#3453)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants