Skip to content

Conversation

@naughtont3
Copy link

Signed-off-by: Thomas Naughton [email protected]
Co-authored-by: Jeff Squyres [email protected]

Signed-off-by: Thomas Naughton <[email protected]>
Co-authored-by: Jeff Squyres <[email protected]>
@naughtont3
Copy link
Author

Replacement for open-mpi#10770 to add to existing PR on source code bit (open-mpi#10772). A little reworking to move declspec cite out to a note and roll in other feedback.

@jsquyres
Copy link
Owner

jsquyres commented Sep 8, 2022

@naughtont3 I gave you bad advice, sorry -- I told you to put the commit on open-mpi#10772, (which is a v5.0.x PR) but I really should have said open-mpi#10762 (which is a master PR, and has now already merged). I.e., we need to get the text merged to OMPI's main branch first, and then bring it to v5.0.x.

So at this point, this text needs to go into a new PR to merge to main, and then we can bring it to v5.0.x. Since it was my mistake to tell you to put it on 10772, I made open-mpi#10780. Can you review it? (since I can't review my own PR). I'll merge it, and then we can add that commit to the existing v5.0.x open-mpi#10772.

@jsquyres jsquyres closed this Sep 8, 2022
@naughtont3
Copy link
Author

No worries and thanks for making the other PR, approved and on its way. :-) Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants