-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standard format for phone numbers #69
Comments
Great reference! That makes sense but I wonder if we will bundle it straight into the first release of the validator. We will certainly recommend E.164 but it might cause to many headaches while we are getting the project off the ground. |
OK cool. How comfortable do you think people will be with having their phone numbers publicly crawl-able? |
The specification doesn't require phone numbers so it shouldn't be a On Wed, Jul 9, 2014 at 3:44 PM, Ryan Shea [email protected] wrote:
Thomas Davis VP of Tech - Earbits - http://earbits.com |
Yes, of course. Just wondering if people will realize what they're getting into. I have an internal conflict with it myself. I would really like to make my phone number available, but I'm concerned about the risks. Thought you might have some insights on this. |
I wouldn't put my phone# just anywhere online. If you make the phone field mandatory, it'll get populated with crap. As for using E.164: if you're going to force (less readable) standards on people, you might as well prefix it with a schema, like suggested -- but discarded for now -- in the phone/email thread: Remember that the templating will put this on a printed PDF page too. Being too rigid with the formatting of fields may make it less usable for that purpose. (Besides, converting free-form to E.164 by a machine is about as easy as it gets.) |
I don't think it's likely that phonenumbers will be used for searching/sorting, so it's really up to the creator of the resume to put in that field what s/he wants. So I vote not to require some standard. |
I vote not to do either for now, need a label that puts things on the back burner. Maybe use Github milestones? |
Based on your arguments, I agree, probably best not to enforce it, at least for now. Like you said, too much of a headache. |
Though I want to keep this issue for future reference without closing it. So going to label as "Backlog" |
Actually will close and reference in README as ideas to reinvestigate |
a lot of places I've seen implement phone numbers as an object with a country code and then the phone number itself. Whoever ingests the data is the one that needs to figure out how to display it. We could always have a standard that this object can be used or a string if you want to keep backwards compatibility |
I think for now we are looking into having a standard format of the phone number field in addition to helper tools/libs, which make it easy for theme developers to parse phone data into this standard format. This is just a vague idea and will probably be done post-v1. |
My unsolicited input having work several years in telco and handling phone numbers using the MVC paradigm. Perhaps a solution would be to have 2 optional fields for phone numbers: |
Couldn't there be a standard format for phone numbers? I'm just thinking that this could be helpful for any application that enables calling and reads the JSON resumes.
@mwaclawek said: Should definitely be E.164
The text was updated successfully, but these errors were encountered: