Skip to content

Conversation

DannyvdSluijs
Copy link
Collaborator

@DannyvdSluijs DannyvdSluijs commented Jun 25, 2025

This PR will:

  • Introduce the JsonSchema\Constraints\Drafts\Draft06 namespace
  • A constraint per keyword
  • Enable the draft6 in the test, locally I have 633 passing test, 312 failing tests and 157 ignored tests.

Update 22-08-2025:

This PR has progressed nicely over time with a minimal impact on existing code. I'm currently trying to resolve the remaining issues from the pipeline (tests, style and static analysis) as well as fix quick wins/hardcoded solutions specific for Draft06

@DannyvdSluijs
Copy link
Collaborator Author

Locally I now have 754 passing test, 213 failing tests and 135 ignored tests.

@DannyvdSluijs
Copy link
Collaborator Author

Locally I now have 754 passing test, 213 failing tests and 135 ignored tests.

Now 773 passing, 207 failing and 122 ignored

@DannyvdSluijs
Copy link
Collaborator Author

DannyvdSluijs commented Jun 27, 2025

Now 773 passing, 207 failing and 122 ignored

849 passing, 181 failing and 72 ignored

@DannyvdSluijs
Copy link
Collaborator Author

Now 773 passing, 207 failing and 122 ignored

849 passing, 181 failing and 72 ignored

886 passing, 145 failing and 71 ignored

@DannyvdSluijs
Copy link
Collaborator Author

Now 773 passing, 207 failing and 122 ignored

849 passing, 181 failing and 72 ignored

886 passing, 145 failing and 71 ignored

953 passing, 78 failing and 71 ignored

@DannyvdSluijs
Copy link
Collaborator Author

Now 773 passing, 207 failing and 122 ignored

849 passing, 181 failing and 72 ignored

886 passing, 145 failing and 71 ignored

953 passing, 78 failing and 71 ignored

961 passing, 70 failing and 71 ignored

@DannyvdSluijs
Copy link
Collaborator Author

Now 773 passing, 207 failing and 122 ignored

849 passing, 181 failing and 72 ignored

886 passing, 145 failing and 71 ignored

953 passing, 78 failing and 71 ignored

961 passing, 70 failing and 71 ignored

978 passing, 69 failling and 55 ignored

@DannyvdSluijs
Copy link
Collaborator Author

Now 773 passing, 207 failing and 122 ignored

849 passing, 181 failing and 72 ignored

886 passing, 145 failing and 71 ignored

953 passing, 78 failing and 71 ignored

961 passing, 70 failing and 71 ignored

978 passing, 69 failling and 55 ignored

991 passing, 56 failling and 55 ignored

@DannyvdSluijs DannyvdSluijs force-pushed the draft-06-support branch 3 times, most recently from a5fc2ea to 1861371 Compare July 1, 2025 17:54
@DannyvdSluijs
Copy link
Collaborator Author

Now 773 passing, 207 failing and 122 ignored

849 passing, 181 failing and 72 ignored

886 passing, 145 failing and 71 ignored

953 passing, 78 failing and 71 ignored

961 passing, 70 failing and 71 ignored

978 passing, 69 failling and 55 ignored

991 passing, 56 failling and 55 ignored

1025 passing, 20 failing and 57 ignored

@DannyvdSluijs
Copy link
Collaborator Author

Now 773 passing, 207 failing and 122 ignored

849 passing, 181 failing and 72 ignored

886 passing, 145 failing and 71 ignored

953 passing, 78 failing and 71 ignored

961 passing, 70 failing and 71 ignored

978 passing, 69 failling and 55 ignored

991 passing, 56 failling and 55 ignored

1025 passing, 20 failing and 57 ignored

1049 passing, 20 failing and 33 ignored

@DannyvdSluijs
Copy link
Collaborator Author

Now 773 passing, 207 failing and 122 ignored

849 passing, 181 failing and 72 ignored

886 passing, 145 failing and 71 ignored

953 passing, 78 failing and 71 ignored

961 passing, 70 failing and 71 ignored

978 passing, 69 failling and 55 ignored

991 passing, 56 failling and 55 ignored

1025 passing, 20 failing and 57 ignored

1049 passing, 20 failing and 33 ignored

1075 passing, 20 failing and 7 ignored

@DannyvdSluijs DannyvdSluijs marked this pull request as ready for review August 29, 2025 13:59
@DannyvdSluijs DannyvdSluijs changed the title feat: add proof-of-concept implementation for strict fully validating using draft-06 schema feat: add implementation for strict fully validating using draft-06 schema Oct 10, 2025
DannyvdSluijs and others added 27 commits October 10, 2025 13:14
These test cases are complex edge cases which perhaps no one will ever use. Rather haft support for draft 6 supporting the vast majority instead of being 100% complete somewhere in the future.
@DannyvdSluijs DannyvdSluijs merged commit 53725e0 into master Oct 10, 2025
17 checks passed
@DannyvdSluijs DannyvdSluijs deleted the draft-06-support branch October 10, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants