Backport CI changes to 5.x.x branch #672
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to GH Actions
… right class (JsonSchema\Constraints\Constraint instead of JsonSchema\Constraints\BaseConstraint). Closes jsonrainbow#654 (jsonrainbow#655) Co-authored-by: Emmanuel GUITON <[email protected]> Co-authored-by: Jordi Boggiano <[email protected]>
|
|
||
| steps: | ||
| - name: "Checkout" | ||
| uses: "actions/checkout@v2" |
There was a problem hiding this comment.
Due to time passing this should now be v4
Suggested change
| uses: "actions/checkout@v2" | |
| uses: "actions/checkout@v4" |
|
|
||
| steps: | ||
| - name: "Checkout" | ||
| uses: "actions/checkout@v2" |
There was a problem hiding this comment.
Suggested change
| uses: "actions/checkout@v2" | |
| uses: "actions/checkout@v4" |
|
|
||
| steps: | ||
| - name: "Checkout" | ||
| uses: "actions/checkout@v2" |
There was a problem hiding this comment.
Suggested change
| uses: "actions/checkout@v2" | |
| uses: "actions/checkout@v4" |
|
|
||
| - name: Run PHPStan | ||
| run: | | ||
| composer require --dev phpstan/phpstan:^0.12.93 marc-mabe/php-enum-phpstan ${{ env.COMPOSER_FLAGS }} |
There was a problem hiding this comment.
Suggested change
| composer require --dev phpstan/phpstan:^0.12.93 marc-mabe/php-enum-phpstan ${{ env.COMPOSER_FLAGS }} | |
| composer require --dev phpstan/phpstan:^1.5 marc-mabe/php-enum-phpstan ${{ env.COMPOSER_FLAGS }} |
In cd8ec4f you've updated to version 1.5 of PHPStan
|
|
||
| steps: | ||
| - name: "Checkout" | ||
| uses: "actions/checkout@v2" |
There was a problem hiding this comment.
Suggested change
| uses: "actions/checkout@v2" | |
| uses: "actions/checkout@v4" |
| # JSON Schema for PHP | ||
|
|
||
| [](https://travis-ci.org/justinrainbow/json-schema) | ||
| [](https://github.com/justinrainbow/json-schema/actions) |
There was a problem hiding this comment.
Suggested change
| [](https://github.com/justinrainbow/json-schema/actions) | |
| [](https://github.com/jsonrainbow/json-schema/actions) |
| 'no_useless_else' => true, | ||
| 'no_useless_return' => true, | ||
| 'ordered_imports' => true, | ||
| 'phpdoc_no_package' => false, |
There was a problem hiding this comment.
If we want to make this update date from the current master should we also port 19ed8ac in?
|
Hey tbh i think I'd bury this PR as well as v5.. Focus on moving forward. Once v6 is out there's no reason to keep using v5 imo |
|
Closing as per author indication which I helps with the focus for v6.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports: