Fix php warning, docblocks, and peephole optimizations #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…operties" ``` There was 1 error: 1) JsonSchema\Tests\SchemaStorageTest::testMissingProperties Creating default object from empty value /Development/json-schema/src/JsonSchema/SchemaStorage.php:64 /Development/json-schema/tests/SchemaStorageTest.php:334 ```
|
@robocoder in an attempt to cleanup this repo we are trying to filter the pull requests and see which ones might be closed. This PR seems to address some smaller issues (paper cut size) which still could use some attention but that would require a rebase of the PR in order to consider it for merging. Feel free to close it yourself or comment in order to help revive this library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.