[BUGFIX] Apply defaults in $ref'ed property / item definitions #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that siblings of $ref are ignored, per the spec.
|
@shmax Any chance of a code review? |
erayd
changed the title
|
LGTM! |
erayd
pushed a commit
to erayd/json-schema
that referenced
this pull request
Feb 14, 2018
[BUGFIX] Apply defaults in $ref'ed property / item definitions
Merged
|
Thanks guys :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Dereference property and array item definitions prior to checking for a default value. Fixes #473.
Why
Because the spec says:
$ref(sodefaultisn't valid here anyway); anddefaultdefined in the reference target.