Fix: Mark check() and coerce() as deprecated #476
Conversation
| try { | ||
| $validator = new JsonSchema\Validator(); | ||
| $validator->check($data, $schema); | ||
| $validator->validate($data, $schema); |
There was a problem hiding this comment.
Probably makes sense to use Validator::validate() here.
localheinz
force-pushed
the
fix/deprecate
branch
from
8cf5b90 to
e5efe21
Compare
| // Validate | ||
| $validator = new JsonSchema\Validator(); | ||
| $validator->check($data, (object) array('$ref' => 'file://' . realpath('schema.json'))); | ||
| $validator->validate($data, (object) array('$ref' => 'file://' . realpath('schema.json'))); |
There was a problem hiding this comment.
Probably makes sense to use Validator::validate() here, too.
localheinz
force-pushed
the
fix/deprecate
branch
2 times, most recently
from
d54234b to
3b34779
Compare
| $v = new Validator(); | ||
| $this->setExpectedException('\JsonSchema\Exception\InvalidArgumentException'); | ||
| $v->check(json_decode('{}'), json_decode('')); | ||
| $v->validate(json_decode('{}'), json_decode('')); |
There was a problem hiding this comment.
You cannot use validate() in this situation, as the first argument is a reference. If you want to change this, you'll need to decode the document into an intermediate variable first, and then pass the variable.
tests/ValidatorTest.php
Outdated
| } | ||
|
|
||
| public function testCheck() | ||
| public function testDeprecatedCheckStillValidates() |
There was a problem hiding this comment.
Method name needs clarification - validation in this test is supposed to fail, but the new name falsely implies that success is the intended outcome.
There was a problem hiding this comment.
How about I rename both to test.*DelegatesToValidate()?
There was a problem hiding this comment.
That works :-). I'm not particularly fussed what they are named, as long as they're not ambiguous and give a reasonable idea of the intended purpose.
localheinz
force-pushed
the
fix/deprecate
branch
from
3b34779 to
179c06d
Compare
localheinz
force-pushed
the
fix/deprecate
branch
from
179c06d to
284f3e5
Compare
|
Updated! |
|
Thank you, @bighappyface and @erayd! |
3 participants
This PR
Validator::check()andValidator::coerce()as deprecated