Skip to content

Conversation

fre5h
Copy link
Contributor

@fre5h fre5h commented Oct 25, 2017

No description provided.

@erayd
Copy link
Contributor

erayd commented Oct 25, 2017

Please change the base branch for this PR to 6.0.0-dev. Otherwise looks good :-).

@fre5h fre5h changed the base branch from master to 6.0.0-dev October 25, 2017 17:54
@fre5h
Copy link
Contributor Author

fre5h commented Oct 25, 2017

@erayd done

@erayd
Copy link
Contributor

erayd commented Oct 25, 2017

Thanks. Could you please rebase it also? Looks like there are a couple of commits in the history for this PR that don't belong there (pulled from master)

@fre5h
Copy link
Contributor Author

fre5h commented Oct 25, 2017

@erayd rebased

@erayd
Copy link
Contributor

erayd commented Oct 25, 2017

Perfect - thank you :-).

@bighappyface bighappyface changed the base branch from 6.0.0-dev to master November 12, 2017 17:40
@bighappyface bighappyface merged commit dfdcb5b into jsonrainbow:master Nov 12, 2017
@erayd erayd mentioned this pull request Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants