Don't add a file:// prefix to URI that already have a scheme
#455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some URI types do not pass validation against \FILTER_VAR_URL (e.g. phar://), but are still valid and still have a scheme. This patch catches those situations via a simple regex.
This was referenced Oct 5, 2017
bighappyface
reviewed
Oct 5, 2017
| if ( | ||
| !is_null($baseUri) && | ||
| !filter_var($baseUri, \FILTER_VALIDATE_URL) && | ||
| !preg_match('|^[^/]+://|u', $baseUri) |
There was a problem hiding this comment.
Pipe | delimiter so that you do not need to escape the forward slash / characters, correct?
|
Yup. It looks neater, and it's easier for a human to quickly understand the regex at a glance. |
erayd
added a commit
to erayd/json-schema
that referenced
this pull request
Oct 10, 2017
…ainbow#455) Some URI types do not pass validation against \FILTER_VAR_URL (e.g. phar://), but are still valid and still have a scheme. This patch catches those situations via a simple regex.
bighappyface
pushed a commit
that referenced
this pull request
Oct 10, 2017
…#457) Some URI types do not pass validation against \FILTER_VAR_URL (e.g. phar://), but are still valid and still have a scheme. This patch catches those situations via a simple regex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add regex filter to URI check when expanding
$ref.Why
Some URI types do not pass validation against
\FILTER_VAR_URL(e.g.phar://), but are still valid and still have a scheme. This patch catches those situations via a simple regex.Fixes #451.