Add composer scripts for php-cs-fixer #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erayd
force-pushed
the
composer-style-scripts
branch
5 times, most recently
from
86703ba to
328a299
Compare
|
Thoughts on TravisCI failure? |
erayd
force-pushed
the
composer-style-scripts
branch
from
328a299 to
71b6fc7
Compare
|
I've been trying to figure out how to resolve it - think I have a solution now. Have set sed to remove the require-dev dependency on php-cs-fixer for hhvm and nightly builds, because php-cs-fixer explicitly conflicts with them, and we're not trying to run it on those platforms anyway. |
|
Yep, that worked - Travis is now happy :-). |
erayd
force-pushed
the
composer-style-scripts
branch
from
71b6fc7 to
c69da1c
Compare
|
Rebased on master following merge of PR #349. |
|
None at all, seems like an elegant enough solution for CI, definitely. :-) |
alcohol
approved these changes
Feb 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
style-checkandstyle-fixscripts to composerWhy