bugfix: patternProperties raised errors when the pattern has slashes #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ribeiropaulor please rebase on master. Thanks for adding the tests. |
…ash. Now the delimiter to evaluate the regex is chosen dynamically.
…rn contained slash.
ribeiropaulor
force-pushed
the
justinrainbow/master
branch
from
1f62a72 to
7099ef0
Compare
|
rebased! |
There was a problem hiding this comment.
$delimiter should be defined and defaulted to a sensible value before this loop. Otherwise, $delimiter is only defined per the loop and will be set the last value if nothing breaks the loop.
|
should be good to merge |
|
+1 |
bighappyface
added a commit
that referenced
this pull request
Dec 3, 2015
bugfix: patternProperties raised errors when the pattern has slashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the delimiter to evaluate the regex is chosen dynamically.