Skip to content

Conversation

gsouf
Copy link
Contributor

@gsouf gsouf commented Oct 15, 2015

git attributes allows to reduce size of dependency, very usefull when you create a phar! More explanations: https://www.reddit.com/r/PHP/comments/2jzp6k/i_dont_need_your_tests_in_my_production

@ktomk
Copy link
Contributor

ktomk commented Nov 2, 2015

Why exclude the `README.md ? It wouldn't contain much info for the zip package but not having one seems unfriendly to me. Maybe better update it?

@bighappyface
Copy link
Collaborator

@gsouf I agree with @ktomk and the first line should be docs

I'll merge with those updates. Good contribution.

@gsouf
Copy link
Contributor Author

gsouf commented Nov 8, 2015

I did put README.md because the only files you need in production are the source files

@bighappyface
Copy link
Collaborator

+1

bighappyface added a commit that referenced this pull request Nov 8, 2015
@bighappyface bighappyface merged commit 77b7e38 into jsonrainbow:master Nov 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants