Skip to content

Conversation

@localheinz
Copy link
Contributor

This PR

  • consistently uses sprintf() for creating error messages
  • consistently uses single quotes instead of double quotes for error messages

Follows #170 (comment).

@bighappyface
Copy link
Collaborator

This one will be tricky. There are others messing with the error messaging:

#122
#142

While I am fine with sprintf I know others are not, and performance impacts are debatable in context of micro-optimization.

I think we need a few people in favor of this one to force the change in convention.

@GrahamCampbell @alecsammon @Maks3w @samkeen thoughts?

@localheinz
Copy link
Contributor Author

@bighappyface

I'm happy to push #122 and #142 forward first!

@doits @onlinesid

What do you think, can you rebase your PRs?

@onlinesid
Copy link
Contributor

@localheinz I have rebased my #142

@bighappyface
Copy link
Collaborator

Closing for now

@localheinz localheinz deleted the fix/consistently-sprintf branch April 14, 2016 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants