Json schema meta validation fails on "items": true

[vuryss]

Hey I'm trying to validate json schema with it's own meta schema as defined in:

https://github.com/json-schema-org/json-schema-spec/tree/main/specs/meta

However in validation of enum schemas, the library fails with error on JsonSchema/Constraints/CollectionConstraint.php:92

Which is reading from this:

https://github.com/json-schema-org/json-schema-spec/blob/5c57ee7de218f8d079227205c1cd0f349b3cf666/specs/meta/validation.json#L23

Because of the "items": true, which seems to be valid according to some:

https://stackoverflow.com/questions/49833963/where-is-defined-behavior-of-true-value-for-schema

May be it's a bug here?

[github-actions]

🚀 @vuryss, thanks for your contribution! Every idea, bug report, and discussion helps make this project better. Your input is invaluable, and we appreciate the time you took to share it. A maintainer will review it soon—stay awesome! 💡✨

⭐ Enjoying contributing? Star the project! ⭐Your contributions help this project grow, and we'd love your support in another way too! If you find this repo helpful, consider leaving a star 🌟 on GitHub.

[DannyvdSluijs]

@vuryss could you provide the actual schema and JSON being validated? And could you include a set of reproduction steps?
Your link to the meta schema links to a folder and not an specific schema. I also want to point out that the repo contains the work in progress. Currently this library only supports draft 3 and draft 4 schemas.

Boolean schema's are actually a thing so it seems this might be a bug indeed. However having the reproduction steps is going to be more effective in getting this solved.

[vuryss]

meta schema links to a folder and not an specific schema

The second link is the exact schema that is used out of all. I just gave the whole directory as an overview of which meta I'm trying to use for validation.

So as a very basic example, I'm validating: {"type":"string","enum":["A","B","C"]} against https://github.com/json-schema-org/json-schema-spec/blob/main/specs/schema.json, which includes the validation one, which is failing, the exact place where this is coming from is the same as in my first comment: https://github.com/json-schema-org/json-schema-spec/blob/5c57ee7de218f8d079227205c1cd0f349b3cf666/specs/meta/validation.json#L23

I'm loading the complete meta specification from the above repo like this:

    $validator = new JsonSchema\Validator();
    $validator->validate(
        '{"type":"string","enum":["A","B","C"]}',
        (object) ['$ref' => 'file://'.__DIR__.'/schemas/json-schema/schema.json']
    );

The schema.json is the locally downloaded schema from the above repo.

For a complete working reproduction you can check a project I'm currently working on: https://github.com/vuryss/dokky
To reproduce it, modify tests/schemas/json-schema/meta/validation.json line 23 to be "items": true instead of the temp patch I made "items": {} then execute the tests with vendor/bin/pest and they will fail.

[DannyvdSluijs]

I've taken another look and I now see what you mean. I've been able to reduce it to the following minimal reproduction

Schema

{
    "type": "array",
    "items": true
}

Data

[1, 1.2, "12"]

Stack trace

PHP Fatal error:  Uncaught TypeError: array_key_exists(): Argument #2 ($array) must be of type array, bool given in ./json-schema/src/JsonSchema/Constraints/CollectionConstraint.php:94
Stack trace:
#0 ./json-schema/src/JsonSchema/Constraints/CollectionConstraint.php(94): array_key_exists(0, true)
#1 ./json-schema/src/JsonSchema/Constraints/CollectionConstraint.php(55): JsonSchema\Constraints\CollectionConstraint->validateItems(Array, Object(stdClass), Object(JsonSchema\Entity\JsonPointer), NULL)
#2 ./json-schema/src/JsonSchema/Constraints/Constraint.php(71): JsonSchema\Constraints\CollectionConstraint->check(Array, Object(stdClass), Object(JsonSchema\Entity\JsonPointer), NULL)
#3 ./json-schema/src/JsonSchema/Constraints/UndefinedConstraint.php(71): JsonSchema\Constraints\Constraint->checkArray(Array, Object(stdClass), Object(JsonSchema\Entity\JsonPointer), NULL)
#4 ./json-schema/src/JsonSchema/Constraints/UndefinedConstraint.php(56): JsonSchema\Constraints\UndefinedConstraint->validateTypes(Array, Object(stdClass), Object(JsonSchema\Entity\JsonPointer), NULL)
#5 ./json-schema/src/JsonSchema/Constraints/Constraint.php(122): JsonSchema\Constraints\UndefinedConstraint->check(Array, Object(stdClass), Object(JsonSchema\Entity\JsonPointer), NULL, false)
#6 ./json-schema/src/JsonSchema/Constraints/SchemaConstraint.php(95): JsonSchema\Constraints\Constraint->checkUndefined(Array, Object(stdClass), NULL, NULL)
#7 ./json-schema/src/JsonSchema/Validator.php(72): JsonSchema\Constraints\SchemaConstraint->check(Array, Object(stdClass))
#8 ./json-schema/issues/799/minimal-repro.php(31): JsonSchema\Validator->validate(Array, Object(stdClass))
#9 {main}
  thrown in ./json-schema/src/JsonSchema/Constraints/CollectionConstraint.php on line 94

[DannyvdSluijs]

This was resolved in #801 and release 6.2.1 was made.

Thanks for the report and feedback.