Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Interlink terms in UJS with the glossary #520

Merged

Conversation

lalitkumawat1m
Copy link
Contributor

What kind of change does this PR introduce?
Documentation Enhancement

Issue Number:

Screenshots/videos:

If relevant, did you update the documentation?
Yes

Summary

Does this PR introduce a breaking change?
No

@lalitkumawat1m lalitkumawat1m requested a review from a team as a code owner March 13, 2024 00:28
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments regarding linking, JSON, JSON + Schema and draft.

Please apply my comments across and let's make another review aftherwards.

Great job!

@@ -8,7 +8,7 @@ Understanding JSON Schema

<img src="understanding/octopus.svg" className="w-1/2 float-right" />

JSON Schema is a powerful tool for validating the structure of JSON
[JSON](../learn/glossary#json) [Schema](../learn/glossary#schema) is a powerful tool for validating the structure of JSON
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON Schema is one single thing, please dont make this separation of terms.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I understand that they are one single thing but I did not find one single glossary term for JSON schema. JSON and schema are separate glossary term in glossary page. How do I point them to single glossary term ? Could you please give me idea about that?

@@ -17,7 +17,7 @@ instructor for JSON Schema. It\'s for those that want to write it and
understand it, but maybe aren\'t interested in building their own
car—er, writing their own JSON Schema validator — just yet.

> This tutorial describes JSON Schema draft 2020-12. Earlier versions of
> This tutorial describes JSON Schema [draft](../learn/glossary#draft) 2020-12. Earlier versions of
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add a link to draft when draft is being used alone without pointing to one specific draft version. the version of this draft is "draft 2020-12" everything together. We'll link to draft when the word is used alone.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I will correct it.

@@ -6,7 +6,7 @@ section: "docs"
If you\'ve ever used XML Schema, RelaxNG or ASN.1 you probably already
know what a schema is and you can happily skip along to the next
section. If all that sounds like gobbledygook to you, you\'ve come to
the right place. To define what JSON Schema is, we should probably first
the right place. To define what [JSON](../learn/glossary#json) [Schema](../learn/glossary#schema) is, we should probably first
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON Schema is one single thing, please dont make this separation of terms.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON and schema are separate glossary term in glossary page. How do I interlink them to single glossary term ?

and hopefully justified the need for schema languages. Here, we proceed
to write a simple JSON Schema.
to write a simple [JSON](../learn/glossary#json) Schema.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON Schema is one single thing, please dont make this separation of terms.

@@ -5,11 +5,11 @@ title: "Conventions used in this documentation"

## Language-specific notes

The names of the basic types in JavaScript and JSON can be confusing
The names of the basic types in JavaScript and [JSON](../learn/glossary#json) can be confusing
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll avoid interlinking JSON because everybody knows it and it is everywhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I will undo it.

when coming from another dynamic language. I\'m a Python programmer by
day, so I\'ve notated here when the names for things are different from
what they are in Python, and any other Python-specific advice for using
JSON and JSON Schema. I\'m by no means trying to create a Python bias to
JSON and JSON [Schema](../learn/glossary#schema). I\'m by no means trying to create a Python bias to
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON Schema is one single thing, please dont make this separation of terms.

@lalitkumawat1m
Copy link
Contributor Author

Hey @benjagm,
Okay I understand that they are one single thing but I did not find one single glossary term for JSON schema. JSON and schema are separate glossary term in glossary page. How do I point them to single glossary term ? Could you please give me idea about that?

@lalitkumawat1m lalitkumawat1m requested a review from benjagm March 16, 2024 15:38
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Lalit! Just left few suggestions to avoid using link to glossary when referring to specific Drafts of json schema.

pages/understanding-json-schema/reference/object.md Outdated Show resolved Hide resolved
pages/understanding-json-schema/reference/schema.md Outdated Show resolved Hide resolved
pages/understanding-json-schema/structuring.md Outdated Show resolved Hide resolved
@lalitkumawat1m lalitkumawat1m requested a review from benjagm April 11, 2024 10:16
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Lalit!! Thanks for this!

@benjagm benjagm merged commit fb9196a into json-schema-org:main Apr 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interlink terms in UJS with the glossary
2 participants