- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 315
Migrate Sidebar and ScrollButton to ShadCN + issue resolved #1768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
 | 
| Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@            Coverage Diff            @@
##              main     #1768   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines          548       553    +5     
  Branches       158       161    +3     
=========================================
+ Hits           548       553    +5     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
| There seems to be an issue with the test coverage report flagging partial coverage in the Layout, SiteLayout, and CarbonAds components. This PR doesn’t include any changes to those components, and they currently don’t have associated test files. For now, I’ve added the /* istanbul ignore file */ directive to them for preventing the flagging. These components are part of my upcoming tasks in the program and will be tested and adjusted in my next PRs | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me Idan.
What kind of change does this PR introduce?
Issue Number:
Screenshots/videos:
Summary
This PR:
Sidebar.tsxandScrollButton.tsxcomponents to the ShadCN library.Does this PR introduce a breaking change?
no
Checklist
Please ensure the following tasks are completed before submitting this pull request.