Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operators : Not Like, Start With, Not Start with, End With, Not … #705

Closed
wants to merge 1 commit into from
Closed

Conversation

absymylyar
Copy link

I Added the operators Not Like, Start With, Not Start with, End With, Not End With

@bart-degreed
Copy link
Contributor

Nice addition! A few remarks:

  • Do they all translate into SQL or do they execute client-side?
  • I believe it would be better to spell out the operator names instead of the abbreviations for clarity
  • Unit tests are missing
  • Documentation needs to be updated

But I'm quite new on the project, so before putting a lot of work into this, I'd recommend to wait and see what the project owners feel about the new operators.

@maurei thoughts?

@absymylyar
Copy link
Author

I've been using those operators for 3 months now on my own project, angular 7 with DevExtrem Datagrid.
I can plug it directly to the API, translating the grid's filter to JsonApi format...

@absymylyar
Copy link
Author

I'm working also to use DateTime and TimeSpan as "HasOne" relationship, and make their properties (year, month, day, dayofweek, etc...) available for filtering and sorting.

@bart-degreed
Copy link
Contributor

Superseded by #792.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants