Skip to content

Update to .NET 6 with EF Core 6 #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Dec 8, 2021
Merged

Update to .NET 6 with EF Core 6 #1122

merged 29 commits into from
Dec 8, 2021

Conversation

bart-degreed
Copy link
Contributor

@bart-degreed bart-degreed commented Dec 2, 2021

Overview:

The cibuild fails because it times out, caused by the large diff. I've verified locally and all looks good. Green build (with cleanupcode/inspectcode disabled) here.

Closes #1109.
Closes #1121.

QUALITY CHECKLIST

  • Changes implemented in code
  • Complies with our contributing guidelines
  • Adapted tests
  • Documentation updated
  • N/A: Created issue to update Templates: {ISSUE_NUMBER}

@bart-degreed bart-degreed force-pushed the net60 branch 9 times, most recently from a82f108 to 5c162a2 Compare December 3, 2021 17:37
@bart-degreed bart-degreed force-pushed the net60 branch 4 times, most recently from b4c2f5e to 2aed0fc Compare December 4, 2021 21:45
@codecov
Copy link

codecov bot commented Dec 4, 2021

Codecov Report

Merging #1122 (049e076) into master (9c9a4f2) will increase coverage by 0.06%.
The diff coverage is 82.98%.

❗ Current head 049e076 differs from pull request most recent head b929647. Consider uploading reports for the commit b929647 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1122      +/-   ##
==========================================
+ Coverage   89.41%   89.48%   +0.06%     
==========================================
  Files         245      241       -4     
  Lines        7294     7198      -96     
==========================================
- Hits         6522     6441      -81     
+ Misses        772      757      -15     
Impacted Files Coverage Δ
...NetCoreExample/Controllers/NonJsonApiController.cs 0.00% <0.00%> (ø)
...NetCoreExample/Controllers/OperationsController.cs 0.00% <0.00%> (ø)
...ples/JsonApiDotNetCoreExample/Data/AppDbContext.cs 0.00% <0.00%> (ø)
...otNetCoreExample/Definitions/TodoItemDefinition.cs 0.00% <0.00%> (ø)
...Examples/JsonApiDotNetCoreExample/Models/Person.cs 0.00% <0.00%> (ø)
...rc/Examples/JsonApiDotNetCoreExample/Models/Tag.cs 0.00% <0.00%> (ø)
...amples/JsonApiDotNetCoreExample/Models/TodoItem.cs 0.00% <0.00%> (ø)
src/Examples/JsonApiDotNetCoreExample/Program.cs 0.00% <0.00%> (ø)
...Core/AtomicOperations/MissingTransactionFactory.cs 0.00% <0.00%> (ø)
...sonApiDotNetCore/Diagnostics/CascadingCodeTimer.cs 0.00% <0.00%> (ø)
... and 352 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c9a4f2...b929647. Read the comment docs.

@bart-degreed bart-degreed force-pushed the net60 branch 5 times, most recently from b980b46 to 9ba4cf8 Compare December 7, 2021 11:14
@bart-degreed bart-degreed force-pushed the net60 branch 2 times, most recently from 5e46380 to b929647 Compare December 8, 2021 10:41
@bart-degreed bart-degreed requested a review from maurei December 8, 2021 12:14
@bart-degreed bart-degreed merged commit 19f6557 into master Dec 8, 2021
@bart-degreed bart-degreed deleted the net60 branch December 8, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Breaking changes in PostgreSQL provider for EF Core 6 Version 5 for .NET 6 Support
2 participants