Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an option preferred encodings array #59

Merged
merged 2 commits into from
Aug 31, 2024

Conversation

danielgindi
Copy link
Contributor

Will be used in expressjs/compression#172

@danielgindi
Copy link
Contributor Author

@dougwilson Would you mind adding a minor change to accepts if/when this PR is merged? This will save some time. Then I'll revert the brotli branch to use accepts module with a simple extra argument.

@nicksrandall
Copy link

@dougwilson thanks for shepherding this along.

@wesleytodd wesleytodd merged commit 8f58d74 into jshttp:1.x Aug 31, 2024
8 checks passed
@wesleytodd
Copy link
Member

After merging this I was looking at the api and realized we are limiting ourselves by passing an array directly, so I wrapped it in an options object so we have less of a chance of needing to break that api in future changes. That is what I will release with 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants