Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in pre-commit example from README.md #25

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

syserr0r
Copy link

Hopefully self-explanatory

*Sending signal to you that this should get the magical label to silence the CHANGELOG entry check.*

@jsh9
Copy link
Owner

jsh9 commented May 22, 2023

Thanks @syserr0r for correcting this typo!

@jsh9
Copy link
Owner

jsh9 commented May 22, 2023

Sending signal to you that this should get the magical label to silence the CHANGELOG entry check.

Hi @syserr0r , could you explain what this means? I implemented the CHANGELOG entry check in Github workflow, but I think it's a bit buggy, so I'm actually thinking about disabling them.

@syserr0r
Copy link
Author

syserr0r commented May 22, 2023

Sending signal to you that this should get the magical label to silence the CHANGELOG entry check.

Hi @syserr0r , could you explain what this means? I implemented the CHANGELOG entry check in Github workflow, but I think it's a bit buggy, so I'm actually thinking about disabling them.

It was in the placeholder text for the PR -- it said to send you the signal if it should get the magical label to silence the CHANGELOG entry check ¯\_(ツ)_/¯

The source is from here in your repo: https://github.com/jsh9/cercis/blob/main/.github/PULL_REQUEST_TEMPLATE.md?plain=1#L16-L17

@jsh9
Copy link
Owner

jsh9 commented May 23, 2023

Ah I see. I inherited this template from Black when I forked it, so I didn't immediately realize where it came from.

@jsh9 jsh9 merged commit aa6a8e0 into jsh9:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants