Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tests #504

Merged
merged 44 commits into from
Mar 18, 2024
Merged

E2E tests #504

merged 44 commits into from
Mar 18, 2024

Conversation

alexey-yarmosh
Copy link
Member

@alexey-yarmosh alexey-yarmosh commented Mar 11, 2024

Part of #281

Copy link
Member

@MartinKolarik MartinKolarik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to run this from both repos as discussed in the original issue, I'm wondering if it would make sense to make these tests a separate repo, which could then be fetched from both the API and the probe. Wdyt @alexey-yarmosh ?

test-e2e/docker.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
.eslintrc Outdated Show resolved Hide resolved
public/v1/components/schemas.yaml Show resolved Hide resolved
test/plugins/oas/index.js Outdated Show resolved Hide resolved
@alexey-yarmosh
Copy link
Member Author

If we want to run this from both repos as discussed in the original issue, I'm wondering if it would make sense to make these tests a separate repo, which could then be fetched from both the API and the probe.

I think storing them in API repo and fetching from probe repo will be more comfortable. Most of the updates/additions to e2e will be related either to API code or to schema.yaml, so API repo will be updated in most of the cases. And syncing updates across 3 repos may become inconvenient during development and while making CI green.

@alexey-yarmosh
Copy link
Member Author

Lets merge that and proceed with probe e2e tests in a new PRs.

@MartinKolarik MartinKolarik merged commit 1fd12f6 into master Mar 18, 2024
4 checks passed
@MartinKolarik MartinKolarik deleted the e2e branch March 18, 2024 13:29
MartinKolarik pushed a commit that referenced this pull request Mar 18, 2024
* feat: move from fake ip vars to test types vars

* feat: add mock e2e scripts

* feat: add mocha setup

* feat: run probe container from e2e setup

* ci: trigger e2e

* feat: wait until probe connects

* feat: add failing usage of matchApiSchema

* fix: matchApiSchema method

* fix: mocha throwing ERROR: null in case of ts compilation error

* feat: add util parser

* feat: change runner

* feat: use got response in mocha plugin

* test: add measurement e2e tests

* feat: add e2e wallaby configuration

* feat: move e2e .mocharc

* feat: add e2e folder to tsconfig

* feat: add e2e cases for all measurement types

* fix: http schema

* refactor: move files

* feat: add locations e2e

* fix: add missing nulls to schema

* test: add offline probes tests

* test: add adopted probes tests e2e

* fix: e2e mocharc

* fix: tests order

* feat: run api as docker container

* fix: run api on port 3000

* fix: local run

* refactor: docker manager

* fix: e2e wallaby

* fix: schema hostname format

* fix: remove unused env var

* fix: add missing awaits

* fix: remove manual json.parse

* fix: log measurement status

* feat: disable rtt null

* fix: add wait for disconnect

* ci: trigger

* fix: retrun rtt null back

* refactor: move e2e to test folder

* fix: use db urls from config

* fix: build probe image from github master

* fix: get rtt schema back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants