Errors: always add to line and column properties

Ref #2243 Ref #2219
jscs-dev · May 13, 2016 · 729db94 · 729db94
1 parent bbb03b5
commit 729db94
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 7 deletions.
diff --git a/lib/errors.js b/lib/errors.js
@@ -68,8 +68,8 @@ Errors.prototype = {
             filename: this._file.getFilename(),
             rule: 'parseError',
             message: errorInfo.message,
-            line: errorInfo.loc && errorInfo.loc.line,
-            column: errorInfo.loc && errorInfo.loc.column
+            line: errorInfo.loc ? errorInfo.loc.line : 1,
+            column: errorInfo.loc ? errorInfo.loc.column : 0
         });
     },
 

diff --git a/test/specs/errors.js b/test/specs/errors.js
@@ -124,19 +124,29 @@ describe('errors', function() {
     });
 
     describe('add', function() {
-        var errors;
-        beforeEach(function() {
-            errors = checker.checkString('yay');
-        });
-
         it('should not throw with good parameters', function() {
+            var errors = checker.checkString('yay');
+
             errors.setCurrentRule('anyRule');
             errors.add('msg');
 
             var error = errors.getErrorList()[0];
 
             expect(error.rule).to.equal('anyRule');
         });
+
+        it('adds parser error without `line` & `column` propertys even there is none',
+            function() {
+                var errors = checker.checkString('');
+
+                errors.add(new Error('test'));
+
+                var error = errors.getErrorList()[0];
+
+                expect(error.line).to.equal(1);
+                expect(error.column).to.equal(0);
+            }
+        );
     });
 
     describe('cast', function() {