requireDollarBeforejQueryAssignment: do not blow up on reset parameter

Fixes #2285
jscs-dev · Jul 1, 2016 · 6ae32ac · 6ae32ac
1 parent b419c66
commit 6ae32ac
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/rules/require-dollar-before-jquery-assignment.js b/lib/rules/require-dollar-before-jquery-assignment.js
@@ -139,7 +139,7 @@ module.exports.prototype = {
                 props.forEach(function(prop) {
                     left = prop.key;
 
-                    if (!left.name) {
+                    if (!left || !left.name) {
                         return;
                     }
 

diff --git a/test/specs/rules/require-dollar-before-jquery-assignment.js b/test/specs/rules/require-dollar-before-jquery-assignment.js
@@ -14,6 +14,10 @@ describe('rules/require-dollar-before-jquery-assignment', function() {
             checker.configure({ requireDollarBeforejQueryAssignment: true });
         });
 
+        it('should not blow up on rest params', function() {
+            expect(checker.checkString('var x = {...test}')).to.have.no.errors();
+        });
+
         it('should report basic jquery operator', function() {
             expect(checker.checkString('var x = $();'))
               .to.have.one.validation.error.from('requireDollarBeforejQueryAssignment');