maximumLineLength: correctly position error for comment nodes

Fixes #2233
jscs-dev · Jun 4, 2016 · 56ca72b · 56ca72b
1 parent ea1ebb9
commit 56ca72b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/rules/maximum-line-length.js b/lib/rules/maximum-line-length.js
@@ -196,7 +196,7 @@ module.exports.prototype = {
             if (line.length > maximumLineLength) {
                 errors.add(
                     'Line must be at most ' + maximumLineLength + ' characters',
-                    file.getLastTokenOnLine(i + 1)
+                    file.getLastTokenOnLine(i + 1, { includeComments: true })
                 );
             }
         }

diff --git a/test/specs/rules/maximum-line-length.js b/test/specs/rules/maximum-line-length.js
@@ -51,6 +51,13 @@ describe('rules/maximum-line-length', function() {
             expect(error.line).to.equal(4);
             expect(error.column).to.equal(9);
         });
+
+        it('should get correct line and column', function() {
+            var error = checker.checkString('\n\n\n123456789').getErrorList()[0];
+
+            expect(error.line).to.equal(4);
+            expect(error.column).to.equal(9);
+        });
     });
 
     describe('allExcept["comments"] option', function() {