Add a template page #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Добавляю преподавателя (@GSemikozov) для код-ревью. |
GSemikozov
requested changes
Dec 4, 2024
|
Добавляю преподавателя (@GSemikozov) для код-ревью. |
|
Решение было обновлено, посмотрим что скажет @GSemikozov |
|
Решение было обновлено, посмотрим что скажет @GSemikozov |
GSemikozov
requested changes
Dec 12, 2024
GSemikozov
requested changes
Dec 16, 2024
GSemikozov
requested changes
Dec 22, 2024
GSemikozov
requested changes
Dec 30, 2024
GSemikozov
requested changes
Jan 29, 2025
| text-align: center; | ||
| text-transform: uppercase; | ||
| color: var(--grey-3); | ||
| padding-bottom: 56px; |
There was a problem hiding this comment.
а зачем здесь паддинг и фон?) это просто текстовый элемент футера
| font-weight: 400; | ||
| font-size: 16px; | ||
| line-height: 24px; | ||
| max-width: 640px; |
| @@ -0,0 +1,15 @@ | |||
| .main { | |||
| max-width: 825px; | |||
There was a problem hiding this comment.
лишнее ограничение (надо на уровне родителя задавать лэйаут)
| <div class="sidebar"> | ||
| <h4 class="sidebar__title">Components</h4> | ||
| <ul> | ||
| <li class="sidebar__text">Modal</li> |
There was a problem hiding this comment.
это должны быть ссылки на внутренние страницы
| <li class="sidebar__text sidebar__text_selected">Histogram</li> | ||
| <li class="sidebar__text">Custom form elements</li> | ||
| </ul> | ||
| <p class="sidebar__text sidebar__text_homelink">Main page</p> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.