Skip to content

signaldb.js.org #8380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
indus merged 1 commit into from
Jul 17, 2023
Merged

signaldb.js.org #8380

indus merged 1 commit into from
Jul 17, 2023

Conversation

@maxnowack
Copy link
Contributor

@maxnowack maxnowack commented Jul 16, 2023

@MattIPv4 MattIPv4 changed the title Update cnames_active.js signaldb.js.org Jul 16, 2023
MattIPv4
MattIPv4 approved these changes Jul 16, 2023
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/maxnowack/signaldb/tree/main/docs

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account labels Jul 16, 2023
@indus indus added the error The page requested returns an error label Jul 16, 2023
@indus
Copy link
Member

indus commented Jul 16, 2023

I've already added your requested subdomain to JS.ORGs zonefile. But as you are using a workflow to deploy the page there may be other steps involved to get the CNAME working. FYI: #7853 (comment)

@maxnowack
Copy link
Contributor Author

maxnowack commented Jul 16, 2023

@indus thanks for the hint. Seems to work now! 👍

@indus indus removed the error The page requested returns an error label Jul 17, 2023
@indus
Copy link
Member

indus commented Jul 17, 2023

Welcome https://signaldb.js.org

@indus indus merged commit ff82d6e into js-org:master Jul 17, 2023
@maxnowack maxnowack deleted the patch-1 branch July 17, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MattIPv4 MattIPv4 MattIPv4 approved these changes

Assignees

No one assigned

Labels

add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maxnowack @indus @MattIPv4