Skip to content

Conversation

@tobysmith568
Copy link
Contributor

@MattIPv4 MattIPv4 changed the title Add license-cop.js.org license-cop.js.org May 8, 2023
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/tobysmith568/license-cop/tree/main/apps/website/src/pages

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account labels May 8, 2023
@indus indus added the error The page requested returns an error label May 9, 2023
@indus
Copy link
Member

indus commented May 9, 2023

I've already added your requested subdomain to JS.ORGs zonefile. But you have to (re-)add a file named CNAME to your branch with the single line license-cop.js.org to make it work.
I'll merge after we have "contact". Please keep this PR open.

@indus
Copy link
Member

indus commented May 9, 2023

I've just seen that you are using a workflow. Because of that there may be other steps involved to get the CNAME working. FYI: #7853 (comment)

@tobysmith568
Copy link
Contributor Author

Hey, thanks for the heads up. Yeah I had to flick this Source dropdown back to "Deploy from a branch" which resulted in a docs/CNAME file being created. This then re-ran my deploy pipeline (because it runs on pushes to main) and then the js.org subdomain stopped getting too many redirects and started 404ing instead.

I then changed the dropdown back to "GitHub Actions (beta)" but nothing changed. I deleted the docs/CNAME file on main (which re-ran my deployment forkflow) and then after that everything is working fine! 🎉

Thanks both! :)

image

@indus indus removed the error The page requested returns an error label May 9, 2023
@indus
Copy link
Member

indus commented May 9, 2023

Welcome https://license-cop.js.org

@indus indus merged commit 45e5ad9 into js-org:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants