Skip to content

Conversation

@chleicated
Copy link
Contributor

@chleicated chleicated commented Dec 10, 2025

The site content is the documentation/website for my npm package yags.js, hosted on Vercel.

@MattIPv4
Copy link
Member

FYI for the future, please just edit your existing PR instead of creating an entirely new one.

cc #10391

@MattIPv4 MattIPv4 changed the title yags.js.org fixed yags.js.org Dec 10, 2025
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi! You need to fill out the PR description template that was provided to you when you created your PR, as we need the information it requests to process your subdomain request. If you need to reference the template again, it can be found at https://raw.githubusercontent.com/js-org/js.org/refs/heads/master/PULL_REQUEST_TEMPLATE.md -- the description of your PR must match the format in the template exactly, with you providing the information that it requests.

@MattIPv4 MattIPv4 added the missing information This PR does not have all the requested information in the PR description label Dec 10, 2025
@chleicated
Copy link
Contributor Author

Should i fill it here?

@chleicated
Copy link
Contributor Author

chleicated commented Dec 10, 2025

The site content is the documentation/website for my npm package yags.js, hosted on Vercel.

@MattIPv4
Copy link
Member

You need to edit the PR description, not post it in a comment.

@chleicated
Copy link
Contributor Author

Uhm, i cant really edit the description... because GitHub is not showing a option for it

@MattIPv4
Copy link
Member

image

@chleicated
Copy link
Contributor Author

oh really sorry, GitHub wasn't showing me that option

@chleicated
Copy link
Contributor Author

btw i updated it

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, site has content based on https://yags.vercel.app/

I trust that your site is configured ready to work with the requested js.org subdomain.

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages and removed missing information This PR does not have all the requested information in the PR description labels Dec 10, 2025
@chleicated
Copy link
Contributor Author

i have fixed everything now its ready to merge

@indus
Copy link
Member

indus commented Dec 11, 2025

Welcome https://yags.js.org

@indus indus merged commit 5a40dd7 into js-org:master Dec 11, 2025
6 of 10 checks passed
@chleicated
Copy link
Contributor Author

Hello js.org team,
I want to take down "yags.js.org" as i am no more working on that npm package.
Looking forward for your reply.

@MattIPv4
Copy link
Member

Please open a PR to remove the entry then.

@chleicated
Copy link
Contributor Author

any specific description for that?

@MattIPv4
Copy link
Member

You'll still need to follow the template, but just reference this PR for the content

@MattIPv4 MattIPv4 mentioned this pull request Dec 14, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants