Skip to content

Conversation

@lc-cn
Copy link
Contributor

@lc-cn lc-cn commented Nov 18, 2025

The site content is docs for zhin robot framework,the framework is drive by nodejs,write by typescript

Copilot AI review requested due to automatic review settings November 18, 2025 00:22
Copilot finished reviewing on behalf of lc-cn November 18, 2025 00:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR requests to add a new subdomain "zhin" pointing to "zhin.pages.dev" to the js.org DNS registry. However, the PR template checklist is incomplete and the entry has an alphabetical ordering issue.

  • Adds a new subdomain entry for "zhin"
  • The PR description does not include required information (unchecked boxes, missing site link, and no explanation of site content)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lc-cn lc-cn changed the title Add 'zhin' in cnames_active.js zhin.js.org Nov 18, 2025
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, site has content based on https://zhin.pages.dev/

I trust that your site is configured ready to work with the requested js.org subdomain.

FYI: For Cloudflare Pages, you need to use the Cloudflare API to add the JS.org subdomain you are requesting as a custom domain for the Pages project.

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages labels Nov 18, 2025
@lc-cn
Copy link
Contributor Author

lc-cn commented Nov 18, 2025

CF is another deployments, github pages is ready

@lc-cn
Copy link
Contributor Author

lc-cn commented Nov 18, 2025

please visit https://zhinjs.github.io/zhin/
work by github actions
has add custom domain zhin.js.org

@indus
Copy link
Member

indus commented Nov 18, 2025

I've already added your requested subdomain to JS.ORGs zonefile.

For Cloudflare Pages, you will need to add the JS.ORG subdomain to your project as a custom domain via the API: https://developers.cloudflare.com/api/operations/pages-domains-add-domain -- it is not possible to add the JS.ORG subdomain as a custom domain through the Cloudflare dashboard.

I'll merge after we have "contact". Please keep this PR open.

@indus indus added the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Nov 18, 2025
@lc-cn
Copy link
Contributor Author

lc-cn commented Nov 19, 2025

added

@indus indus removed the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Nov 19, 2025
@indus
Copy link
Member

indus commented Nov 19, 2025

Welcome https://zhin.js.org

@indus indus merged commit c5df74c into js-org:master Nov 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants