-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
zhin.js.org #10335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zhin.js.org #10335
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR requests to add a new subdomain "zhin" pointing to "zhin.pages.dev" to the js.org DNS registry. However, the PR template checklist is incomplete and the entry has an alphabetical ordering issue.
- Adds a new subdomain entry for "zhin"
- The PR description does not include required information (unchecked boxes, missing site link, and no explanation of site content)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MattIPv4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Commit valid, site has content based on https://zhin.pages.dev/
I trust that your site is configured ready to work with the requested js.org subdomain.
FYI: For Cloudflare Pages, you need to use the Cloudflare API to add the JS.org subdomain you are requesting as a custom domain for the Pages project.
|
CF is another deployments, github pages is ready |
|
please visit https://zhinjs.github.io/zhin/ |
|
I've already added your requested subdomain to JS.ORGs zonefile. For Cloudflare Pages, you will need to add the JS.ORG subdomain to your project as a custom domain via the API: https://developers.cloudflare.com/api/operations/pages-domains-add-domain -- it is not possible to add the JS.ORG subdomain as a custom domain through the Cloudflare dashboard. I'll merge after we have "contact". Please keep this PR open. |
|
added |
|
Welcome https://zhin.js.org |
Uh oh!
There was an error while loading. Please reload this page.