Skip to content
This repository was archived by the owner on Feb 26, 2020. It is now read-only.

Release itself#14

Open
FagnerMartinsBrack wants to merge 18 commits into
masterfrom
release-itself
Open

Release itself#14
FagnerMartinsBrack wants to merge 18 commits into
masterfrom
release-itself

Conversation

@FagnerMartinsBrack
Copy link
Copy Markdown
Member

@FagnerMartinsBrack FagnerMartinsBrack commented Apr 3, 2017

The release is just tested manually using npm run release:test

@FagnerMartinsBrack FagnerMartinsBrack force-pushed the release-itself branch 3 times, most recently from ef68167 to 4af588e Compare April 3, 2017 12:55
@FagnerMartinsBrack
Copy link
Copy Markdown
Member Author

FagnerMartinsBrack commented Oct 19, 2017

  • Test the real release thing (npm run release <bumpSpec>)
    • Issue: Code is not handling when the git prompts for a password for the GPG key

Comment thread test/git/git-push.spec.js
});
}); No newline at end of file

describe("Git Push Tag To Remote", function() {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use async/await

Comment thread release.js

let localRepo;

Promise.try(() => {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use async/await

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant