Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax on ActiveRecord gem version identifer. #1157

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Relax on ActiveRecord gem version identifer. #1157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d26ce5
Relax on ActiveRecord gem version identifier.
ruyrocha Aug 10, 2024
7c74a10
Re-enable test serial with trigger.
ruyrocha Aug 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion activerecord-jdbc-adapter.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ Gem::Specification.new do |gem|
gem.executables = gem.files.grep(%r{^bin/}).map { |f| File.basename(f) }
gem.test_files = gem.files.grep(%r{^test/})

gem.add_dependency 'activerecord', '~> 7.1.3'
gem.add_dependency 'activerecord', '~> 7.1'

#gem.add_development_dependency 'test-unit', '2.5.4'
#gem.add_development_dependency 'test-unit-context', '>= 0.3.0'
Expand Down
3 changes: 0 additions & 3 deletions test/db/postgresql/table_name_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,6 @@ class SerialWithTrigger < ActiveRecord::Base
end

def test_serial_with_trigger
pend "Issue happens in active record 7.1 internals, issue wass logged in rails repo"
# issue link: https://github.com/rails/rails/issues/52485

sn = SerialWithTrigger.create!(value: 1_234_567_890.to_s)

assert sn.reload
Expand Down
Loading