Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

death mode #18

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jeniasaigak
Copy link

What:
Added death mode, which can be enabled via -d flag. When the death mode is enabled, the round will be finished as soon as the user will type an incorrect symbol

Why:
If you want to become a good typist, you need to learn to type with no mistakes. This mode will enforce you to think twice on each key press and strongly decrease amount of typing mistakes. This will lead to better typing speed

How:
There is a has_finished function at game related file, which validates if the round is completed. At this PR I've additionally added a check to the function to validate it there are any mistakes in the input field

Checklist:

  • Allow edits from maintainers option checked
  • Branch name is prefixed with [your_username]/ (ex. thatvegandev/featureX)
  • Documentation added
  • Tests added N/A
  • No failing actions
  • Merge ready

@jrnxf
Copy link
Owner

jrnxf commented Jan 7, 2023

this looks awesome! I made a few minor tweaks in a branch of mine that I'll add here! One thing I'd love you opinion on:

What do you think about not showing stats if the user fails in death mode? We could just throw a skull icon in the center of the terminal if they fail maybe. I kinda like the idea of making the seeing stats a rewarding experience if you're in death mode.

@jrnxf jrnxf changed the title Add death mode death mode Jan 7, 2023
@jeniasaigak
Copy link
Author

@jrnxf Your idea sounds great! I've also reviewed changes at your branch, and all of them make sense to me. I'll add it to the PR along with your proposition 👌

jrnxf and others added 2 commits January 13, 2023 15:31
- small cleanup, add death emoji to test if failed in death mode
@jeniasaigak
Copy link
Author

I've just realized that it will be better to show the word and the exact place where you made a typo, along with skull at the bottom line after loosing in the death mode. Will try to implement it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants