Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save empty journal on install instead of just creating a zero-length file #1690

Merged
merged 3 commits into from
Feb 25, 2023
Merged

Save empty journal on install instead of just creating a zero-length file #1690

merged 3 commits into from
Feb 25, 2023

Conversation

micahellison
Copy link
Member

Fixes #1493.

This new test might need some updating after other open PRs are merged.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

@micahellison micahellison added the bug Something isn't working label Feb 24, 2023
wren
wren approved these changes Feb 25, 2023
View reviewed changes
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✏️

@wren wren merged commit 3c87111 into jrnl-org:develop Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wren wren wren approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jrnl should not create 0-length "encrypted" file on startup
2 participants
@micahellison @wren